subkismet Work Item Rss Feed

Commented Issue: Reset Method on CaptchaControl [9191]

assafl2003 — Thu, 22 Dec 2011 23:11:29 GMT

I couldn't find a way to make the CaptchaControl regenerate a new code after it has been successfully validated. Without a way to reset the captcha control you can't prevent a visitor from manually typing in the code once, and then submitting spam after the captcha control is validated.

Please add something like a public method on CaptchaControl that allows you to programmatically set the control to a non-validated state with a new code.
Comments: hope this is still a relevant issue to handle it would help to perform a reset of the control following a valid test I use it after an UpdatePanel callback thanks

Created Issue: GoogleSafeBrowsing: critical bug when removing existing keys [11372]

cmenet — Tue, 04 Oct 2011 09:25:09 GMT

In Synchronizer.cs, the Update method crashes if keys need to be removed.
Can't perform a "keys.Remove(key)" inside the foreach statement.
We could use an old style code instead:

for (int i = keys.Count - 1; i >= 0; i--)
{
Key key = keys[i];
if (key.Type == KeyType.Deletion)
{
DataProviderManager.Provider.RemoveKey(key.Value, listType);
keys.Remove(key);
}
}

Commented Feature: Update Google Safe Browsing API for Version 2.0 of API Specification [11371]

cmenet — Tue, 04 Oct 2011 08:28:36 GMT

Google has a new specification for Safe Browsing API that we have to adapt.
Comments: Any news about adapting to version 2.0? Google planed to stop API v1.0 on December, 31st 2011...

Commented Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to be considered Safe [11367]

cmenet — Tue, 04 Oct 2011 08:15:21 GMT

In Synchronizer.cs CheckLinks() needs to compare the MD5 of the link to the Keys list. Currently compares URL string to MD5 hashes.

Incorrect Code:
foreach (string link in linksToCheck)
{
MD5 md5 = MD5.Create();

if (phishingKeys.Contains(link))
phishingResult++;
else if (malwareKeys.Contains(link))
malwareResult++;
}

Corrected Code:
foreach (string link in linksToCheck)
{
MD5 md5 = MD5.Create();

if (phishingKeys.Contains(GetMd5Hash(link)))
phishingResult++;
else if (malwareKeys.Contains(GetMd5Hash(link)))
malwareResult++;
}
Comments: In this case, you can also remove the following line inside the foreach: MD5 md5 = MD5.Create(); It's useless :)

Created Feature: Update Google Safe Browsing API for Version 2.0 of API Specification [11371]

Keyvan — Sat, 18 Jun 2011 23:47:17 GMT

Google has a new specification for Safe Browsing API that we have to adapt.

Closed Task: Add the Waegis library [11370]

Keyvan — Wed, 15 Jun 2011 02:45:35 GMT

Import the client library for interfacing with Waegis.
Comments: Imported. Closing.

Created Task: Add the Waegis library [11370]

Keyvan — Wed, 15 Jun 2011 02:25:22 GMT

Import the client library for interfacing with Waegis.

Closed Task: Reload the project in .NET 4.0 and VS 2010 [11368]

Keyvan — Sun, 22 May 2011 14:50:39 GMT

Now it's time to reload the project and upgrade to the latest bits of .NET and Visual Studio.
Comments: Done. Closing.

Closed Feature: Add Password Generator component [11369]

Keyvan — Sun, 22 May 2011 14:48:52 GMT

Add a fully customizable password generator component to the project.
Comments: Added. Closing.

Closed Feature: Add automatic update logic to Google Safe Browsing [9160]

Keyvan — Thu, 19 May 2011 12:35:26 GMT

That would be good to have a built-in mechanism for automatic updates of local black lists.
Comments: Closing.

Commented Feature: Add automatic update logic to Google Safe Browsing [9160]

Keyvan — Thu, 19 May 2011 12:34:57 GMT

That would be good to have a built-in mechanism for automatic updates of local black lists.
Comments: This doesn't seem relevant to the scope of this project/library. I think it's natural to leave the updating process to developers. You can use other open source projects like my Abidar (http://abidar.codeplex.com) library to accomplish this.

Edited Feature: Add automatic update logic to Google Safe Browsing [9160]

Keyvan — Thu, 19 May 2011 12:34:57 GMT

That would be good to have a built-in mechanism for automatic updates of local black lists.

Edited Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to be considered Safe [11367]

Keyvan — Thu, 19 May 2011 12:34:26 GMT

Edited Feature: Add Password Generator component [11369]

Keyvan — Thu, 19 May 2011 12:32:53 GMT

Add a fully customizable password generator component to the project.

Created Feature: Add Password Generator component [11369]

Keyvan — Wed, 18 May 2011 13:39:58 GMT

Add a fully customizable password generator component to the project.

Created Task: Reload the project in .NET 4.0 and VS 2010 [11368]

Keyvan — Wed, 18 May 2011 13:38:35 GMT

Now it's time to reload the project and upgrade to the latest bits of .NET and Visual Studio.

Commented Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to be considered Safe [11367]

Keyvan — Wed, 18 May 2011 13:21:06 GMT

In Synchronizer.cs CheckLinks() needs to compare the MD5 of the link to the Keys list. Currently compares URL string to MD5 hashes.

Incorrect Code:
foreach (string link in linksToCheck)
{
MD5 md5 = MD5.Create();

if (phishingKeys.Contains(link))
phishingResult++;
else if (malwareKeys.Contains(link))
malwareResult++;
}

Corrected Code:
foreach (string link in linksToCheck)
{
MD5 md5 = MD5.Create();

if (phishingKeys.Contains(GetMd5Hash(link)))
phishingResult++;
else if (malwareKeys.Contains(GetMd5Hash(link)))
malwareResult++;
}
Comments: Thanks for the comment. I will correct this in the new version.

Edited Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to be considered Safe [11367]

Keyvan — Wed, 18 May 2011 13:21:06 GMT

Edited Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to be considered Safe [11367]

robragan — Mon, 26 Jul 2010 07:08:17 GMT

Created Issue: Critical bug causes all calls to CheckLinks() in GoogleSafeBrowsing to return True [11367]

robragan — Mon, 26 Jul 2010 02:57:49 GMT